Skip to content

Deprecate match filter with packet #1986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 6, 2025
Merged

Deprecate match filter with packet #1986

merged 5 commits into from
Oct 6, 2025

Conversation

Dimi1010
Copy link
Collaborator

@Dimi1010 Dimi1010 commented Oct 2, 2025

As per this comment chain: #1957 (comment)

Deprecated all instances of matchPacketWithFilter.

@Dimi1010 Dimi1010 added refactoring API deprecation Pull requests that deprecate parts of the public interface. labels Oct 2, 2025
Dimi1010
Dimi1010 commented Oct 2, 2025
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Oct 2, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 51.85185% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.41%. Comparing base (47cd680) to head (c0313ad).
⚠️ Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
Tests/Pcap++Test/Tests/FilterTests.cpp 66.66% 0 Missing and 6 partials ⚠️
Pcap++/src/PcapDevice.cpp 0.00% 3 Missing and 1 partial ⚠️
Examples/IPDefragUtil/main.cpp 0.00% 1 Missing ⚠️
Examples/IPFragUtil/main.cpp 0.00% 0 Missing and 1 partial ⚠️
Examples/PcapSplitter/SimpleSplitters.h 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1986      +/-   ##
==========================================
- Coverage   83.44%   83.41%   -0.04%     
==========================================
  Files         311      311              
  Lines       55000    54998       -2     
  Branches    12100    11863     -237     
==========================================
- Hits        45897    45874      -23     
+ Misses       7876     7867       -9     
- Partials     1227     1257      +30
Flag Coverage Δ
alpine320 75.91% <48.00%> (-0.05%) ⬇️
fedora42 75.87% <48.00%> (-0.04%) ⬇️
macos-13 81.57% <29.62%> (-0.04%) ⬇️
macos-14 81.57% <29.62%> (-0.04%) ⬇️
macos-15 81.58% <29.62%> (-0.04%) ⬇️
mingw32 70.61% <33.33%> (-0.07%) ⬇️
mingw64 70.58% <33.33%> (+0.07%) ⬆️
npcap ?
rhel94 75.87% <48.00%> (-0.05%) ⬇️
ubuntu2004 60.15% <20.00%> (-0.03%) ⬇️
ubuntu2004-zstd 60.25% <20.00%> (-0.03%) ⬇️
ubuntu2204 75.81% <48.00%> (-0.06%) ⬇️
ubuntu2204-icpx 60.62% <33.33%> (-0.06%) ⬇️
ubuntu2404 75.91% <48.00%> (-0.04%) ⬇️
ubuntu2404-arm64 75.59% <48.00%> (-0.04%) ⬇️
unittest 83.41% <51.85%> (-0.04%) ⬇️
windows-2022 85.44% <33.33%> (+0.10%) ⬆️
windows-2025 85.46% <33.33%> (+0.05%) ⬆️
winpcap 85.46% <33.33%> (-0.15%) ⬇️
xdp 53.56% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Dimi1010 Dimi1010 marked this pull request as ready for review October 2, 2025 17:13
@Dimi1010 Dimi1010 requested a review from seladb as a code owner October 2, 2025 17:13
seladb
seladb reviewed Oct 3, 2025
View reviewed changes
Copy link
Owner

@seladb seladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dimi1010 can we modify the tests (FilterTests.cpp) to also use match() instead of matchPacketWithFilter()?

@Dimi1010
Copy link
Collaborator Author

Dimi1010 commented Oct 3, 2025

@Dimi1010 can we modify the tests (FilterTests.cpp) to also use match() instead of matchPacketWithFilter()?

Sure, we will drop coverage for the old methods, but I guess it's fine?

seladb
seladb approved these changes Oct 4, 2025
View reviewed changes
Copy link
Owner

@seladb seladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nit comments, otherwise LGTM

@Dimi1010 Dimi1010 merged commit e227b75 into seladb:dev Oct 6, 2025
43 checks passed
@Dimi1010 Dimi1010 deleted the deprecate-match-filter-with-packet branch October 6, 2025 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seladb seladb seladb approved these changes

Assignees
No one assigned
Labels
API deprecation Pull requests that deprecate parts of the public interface. refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dimi1010 @seladb